Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary extra batches in SaveChanges #20664

Closed
4 tasks
Tracked by #26797
AndriySvyryd opened this issue Apr 17, 2020 · 1 comment · Fixed by #27713
Closed
4 tasks
Tracked by #26797

Remove unnecessary extra batches in SaveChanges #20664

AndriySvyryd opened this issue Apr 17, 2020 · 1 comment · Fixed by #27713
Assignees
@roji
Labels
area-perf area-save-changes closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
7.0.0

Comments

@AndriySvyryd
Copy link
Member

AndriySvyryd commented Apr 17, 2020 •
edited
Loading

  • Add API to signal a "batch wall" past which the commands can't be reordered. This would replace the current ModificationCommandBatch.Complete() method.
  • When performing the topological sort only consider the FKs where both entity types have associated commands
  • Consider grouping predecessor map by FK
  • When using client-side value generation, we can stop doing multiple roundtrips when related entities are involved, since there's no need to fetch the primary key from the DB before sending the dependent. This could be a valuable optimization for people using client-side GUID generation (and hi-lo).
@ajcvickers ajcvickers added this to the Backlog milestone Apr 17, 2020
@AndriySvyryd AndriySvyryd self-assigned this Sep 1, 2020
@AndriySvyryd AndriySvyryd mentioned this issue Sep 1, 2020
Closed
@AndriySvyryd
Copy link
Member Author

Related: #3954

@AndriySvyryd AndriySvyryd removed this from the Backlog milestone Nov 4, 2021
@ajcvickers ajcvickers assigned roji and unassigned AndriySvyryd Nov 5, 2021
@ajcvickers ajcvickers added this to the 7.0.0 milestone Nov 5, 2021
This was referenced Jan 14, 2022
Closed
Open
@roji roji mentioned this issue Feb 20, 2022
Closed
@AndriySvyryd AndriySvyryd mentioned this issue Feb 28, 2022
Merged
roji added a commit to roji/efcore that referenced this issue Mar 4, 2022
@roji
WIP on dotnet#20664
6047cfc
@roji roji mentioned this issue Mar 27, 2022
Merged
roji added a commit to roji/efcore that referenced this issue Apr 22, 2022
@roji
Removed unnecessary batching boundaries from topological sort
d12b383 
Closes dotnet#20664
@roji roji changed the title Increase batch size by letting ModificationCommandBatch determine it Remove unnecessary extra batches in SaveChanges Apr 22, 2022
roji added a commit to roji/efcore that referenced this issue Apr 26, 2022
@roji
Removed unnecessary batching boundaries from topological sort
156cbcc 
Closes dotnet#20664
@ghost ghost closed this as completed in #27713 Apr 26, 2022
ghost pushed a commit that referenced this issue Apr 26, 2022
@roji
Removed unnecessary batching boundaries from topological sort (#27713)
8236cb9 
Closes #20664
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-preview5 May 4, 2022
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label May 4, 2022
@ajcvickers ajcvickers mentioned this issue Jun 23, 2022
Closed
@ajcvickers ajcvickers modified the milestones: 7.0.0-preview5, 7.0.0 Nov 5, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-perf area-save-changes closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Reduce SaveChanges roundtrips roji/efcore
3 participants
@ajcvickers @roji @AndriySvyryd