Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trailing underscore to the backing field matching convention #23901

Closed
ajcvickers opened this issue Jan 15, 2021 · 0 comments · Fixed by #24553
Closed

Add trailing underscore to the backing field matching convention #23901

ajcvickers opened this issue Jan 15, 2021 · 0 comments · Fixed by #24553
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@ajcvickers
Copy link
Member

See #23703

So this is not needed:

modelBuilder.Entity<Post>().Navigation(e => e.TagsInPostsData).HasField("tagsInPostsData_");
modelBuilder.Entity<Tag>().Navigation(e => e.PostsInTagsData).HasField("postsInTagsData_")
@ajcvickers ajcvickers added this to the Backlog milestone Jan 15, 2021
@ajcvickers ajcvickers self-assigned this Jan 15, 2021
ajcvickers added a commit that referenced this issue Mar 31, 2021
@ajcvickers
Tweaks for by-convention mapping of gRPC model
6b30900 
Fixes #23703

At some point we started eagerly throwing when attempting to build a setter delegate. This should be lazy because we don't always need a setter.

Fixes #23901

Detects "propertyName_" as a backing field.
@ajcvickers ajcvickers mentioned this issue Mar 31, 2021
Merged
@ajcvickers ajcvickers modified the milestones: Backlog, 6.0.0-preview4 Mar 31, 2021
@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed consider-for-current-release labels Mar 31, 2021
ajcvickers added a commit that referenced this issue Mar 31, 2021
@ajcvickers
Tweaks for by-convention mapping of gRPC model (#24553)
304219c 
Fixes #23703

At some point we started eagerly throwing when attempting to build a setter delegate. This should be lazy because we don't always need a setter.

Fixes #23901

Detects "propertyName_" as a backing field.
@ajcvickers ajcvickers mentioned this issue May 27, 2021
Closed
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview4, 6.0.0 Nov 8, 2021
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Tweaks for by-convention mapping of gRPC model dotnet/efcore
1 participant
@ajcvickers