Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use AddFromFile() in Scaffold-DbContext #24933

Closed
AndriySvyryd opened this issue May 18, 2021 · 2 comments · Fixed by #24937
Closed

Don't use AddFromFile() in Scaffold-DbContext #24933

AndriySvyryd opened this issue May 18, 2021 · 2 comments · Fixed by #24937
Assignees
@bricelam
Labels
area-perf area-tools closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported type-enhancement
Milestone
6.0.0

Comments

@AndriySvyryd
Copy link
Member

It's really slow in new-style csproj
@ErikEJ
Copy link
Contributor

ErikEJ commented May 19, 2021

@AndriySvyryd How about "Add-Migration" (also uses AddFromFile() ) ?

@ErikEJ
Copy link
Contributor

ErikEJ commented May 19, 2021

Ah - saw this: https://github.com/dotnet/efcore/pull/24906/files#r634796433

@ErikEJ ErikEJ mentioned this issue May 19, 2021
Merged
@AndriySvyryd AndriySvyryd added this to the Backlog milestone May 21, 2021
@bricelam bricelam modified the milestones: Backlog, 6.0.0 Jun 7, 2021
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Jun 7, 2021
@bricelam bricelam self-assigned this Jun 7, 2021
@AndriySvyryd AndriySvyryd modified the milestones: 6.0.0, 6.0.0-preview6 Jul 2, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview6, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-perf area-tools closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. community-contribution customer-reported type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Stop using AddFromFile with many files ErikEJ/EntityFramework
4 participants
@bricelam @ajcvickers @ErikEJ @AndriySvyryd