Stop using AddFromFile with many files

[ErikEJ]

("really slow" on SDK style .csproj)

fixes #24933

[AndriySvyryd]

@bricelam Do you think we'll need to add a note in the docs for non-SDK projects to add the files manually?

[ErikEJ]

EF Core 6 will only support .net 5/6 - but this file is global, and also works for 3.1??

[bricelam]

We already skip calling ProjectItem.Remove() when it's not needed (for different reasons), so I just intended to copy that code:

efcore/src/EFCore.Tools/tools/EntityFrameworkCore.psm1

Lines 355 to 362 in b2fc119

	if (!(IsCpsProject $dteProject) -or (GetCpsProperty $dteProject 'EnableDefaultItems') -ne 'true' -or (GetCpsProperty $dteProject 'EnableDefaultCompileItems') -ne 'true')
	{
	$files = $result.migrationFile, $result.metadataFile, $result.snapshotFile
	$files | ?{ $_ -ne $null } | %{
	$projectItem = GetProjectItem $dteProject $_
	if ($projectItem)
	{
	$projectItem.Remove()

[bricelam]

We might as well do it for Add-Migration too

[bricelam]

EF Core 6 will only support .net 5/6 - but this file is global, and also works for 3.1??

Correct, you can use the 6.0 tools with 2.1 projects. This happens when you have a solution with both an EF Core 6 and EF Core 2.1/3.1 project.

[ErikEJ]

I can update for Add-Migration?

[ErikEJ]

@ajcvickers I don't want to nitpick, but I think you forgot to label this "community contribution"

[ajcvickers]

@ErikEJ I'm way behind with this...

[ronaldhoek]

This speaks about 'conditionally' adding the created script files (in the past I already noticed, that remove-migration would not remove the file from the project - so might that also be related).

But based on what/which condition(s)?