Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiled models don't have the correct default namespace/directory #25059

Closed
ajcvickers opened this issue Jun 8, 2021 · 1 comment · Fixed by #25584
Closed

Compiled models don't have the correct default namespace/directory #25059

ajcvickers opened this issue Jun 8, 2021 · 1 comment · Fixed by #25584
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
6.0.0

Comments

@ajcvickers
Copy link
Member

Currently, the compiled model is generated in the same namespace and in the same folder as the existing model. I have found that it is very useful to have the compiled model in its own directory so that it can easily be blown away. We should consider making this the default. (Note this is somewhat similar to generating migrations in \Migrations by default.)
@AndriySvyryd
Copy link
Member

AndriySvyryd commented Jun 9, 2021 •
edited
Loading

EFCoreOptimization
├ CompiledModels
└ PreCompiledQueries

Rooted at the DbContext namespace/folder.
Namespace will mirror the folder structure.

@AndriySvyryd AndriySvyryd mentioned this issue Jun 9, 2021
Closed
@AndriySvyryd AndriySvyryd self-assigned this Jun 9, 2021
@AndriySvyryd AndriySvyryd added this to the 6.0.0 milestone Jun 15, 2021
@AndriySvyryd AndriySvyryd changed the title Decide on the default namespace/directory for compiled models Compiled models don't have the correct default namespace/directory Aug 9, 2021
@ajcvickers ajcvickers mentioned this issue Aug 11, 2021
Closed
24 tasks
AndriySvyryd added a commit that referenced this issue Aug 19, 2021
@AndriySvyryd
Change the default subfolder/subnamespace for compiled models to Comp…
c2dcd7b 
…iledModels

Handle context types in the global namespace

Fixes #25058
Fixes #25059
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 19, 2021
@AndriySvyryd AndriySvyryd removed their assignment Aug 19, 2021
@AndriySvyryd AndriySvyryd modified the milestones: 6.0.0, 6.0.0-rc2 Aug 19, 2021
AndriySvyryd added a commit that referenced this issue Aug 19, 2021
@AndriySvyryd
Change the default subfolder/subnamespace for compiled models to Comp…
ef673e4 
…iledModels

Handle context types in the global namespace

Fixes #25058
Fixes #25059
@AndriySvyryd AndriySvyryd mentioned this issue Aug 19, 2021
Merged
AndriySvyryd added a commit that referenced this issue Aug 19, 2021
@AndriySvyryd
Change the default subfolder/subnamespace for compiled models to Comp…
5d91778 
…iledModels

Handle context types in the global namespace

Fixes #25058
Fixes #25059
AndriySvyryd added a commit that referenced this issue Aug 19, 2021
@AndriySvyryd
Change the default subfolder/subnamespace for compiled models to Comp…
6d7fcbb 
…iledModels

Handle context types in the global namespace

Fixes #25058
Fixes #25059
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc2, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Change the default subfolder/subnamespace for compiled models to CompiledModels dotnet/efcore
2 participants
@ajcvickers @AndriySvyryd