Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlServer: add custom convention which adds a blank trigger to all tables #27531

Closed
1 task done
roji opened this issue Mar 1, 2022 · 1 comment
Closed
1 task done

SqlServer: add custom convention which adds a blank trigger to all tables #27531

roji opened this issue Mar 1, 2022 · 1 comment
Labels
area-save-changes area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
7.0.0

Comments

@roji
Copy link
Member

roji commented Mar 1, 2022 •
edited
Loading

#27372 changes the SQL Server provider to use OUTPUT without INTO in the update pipeline - this is more efficient, but incompatible with triggers. It also adds a per-table opt-in to allow users to switch to the slower OUTPUT with INTO syntax. This issue tracks adding a custom convention which allows doing that globally.

Depends on:

Split out from #27372
@roji roji self-assigned this Mar 1, 2022
@roji roji added the blocked label Mar 1, 2022
@ajcvickers ajcvickers added this to the Backlog milestone Mar 4, 2022
@roji roji removed this from the Backlog milestone Apr 25, 2022
@roji roji mentioned this issue Apr 25, 2022
Closed
@roji
Copy link
Member Author

roji commented Apr 25, 2022

Removing milestone to discuss whether this belongs in 7.0.

@ajcvickers ajcvickers assigned AndriySvyryd and unassigned roji Apr 28, 2022
@ajcvickers ajcvickers added this to the 7.0.0 milestone Apr 28, 2022
@AndriySvyryd AndriySvyryd removed this from the 7.0.0 milestone Aug 13, 2022
@ajcvickers ajcvickers added this to the 7.0.0 milestone Aug 16, 2022
AndriySvyryd added a commit that referenced this issue Aug 16, 2022
@AndriySvyryd
Add a custom convention which adds a blank trigger to all tables
7dd7b8a 
Fixes #27531
AndriySvyryd added a commit that referenced this issue Aug 16, 2022
@AndriySvyryd
Add a custom convention which adds a blank trigger to all tables
052684f 
Fixes #27531
AndriySvyryd added a commit that referenced this issue Aug 16, 2022
@AndriySvyryd
Add a custom convention which adds a blank trigger to all tables
cd3fcab 
Fixes #27531
@AndriySvyryd AndriySvyryd mentioned this issue Aug 16, 2022
Merged
AndriySvyryd added a commit that referenced this issue Aug 16, 2022
@AndriySvyryd
Add a custom convention which adds a blank trigger to all tables
7d5f0ac 
Fixes #27531
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 16, 2022
@AndriySvyryd AndriySvyryd removed their assignment Aug 16, 2022
@ajcvickers ajcvickers modified the milestones: 7.0.0, 7.0.0-rc1 Aug 22, 2022
@roji roji mentioned this issue Aug 26, 2022
Closed
@ajcvickers ajcvickers removed this from the 7.0.0-rc1 milestone Nov 5, 2022
@ajcvickers ajcvickers added this to the 7.0.0 milestone Nov 5, 2022
@ajcvickers ajcvickers mentioned this issue Dec 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-save-changes area-sqlserver closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
3 participants
@ajcvickers @roji @AndriySvyryd