Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevEng: Remove our Razor dependency #2947

Closed
divega opened this issue Aug 27, 2015 · 2 comments
Closed

RevEng: Remove our Razor dependency #2947

divega opened this issue Aug 27, 2015 · 2 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone

Comments

@divega
Copy link
Contributor

divega commented Aug 27, 2015

After reviewing the outcome of trying to use Razor to generate C# code in our templates and we have come to the conclusion that it is probably not the right thing to do for the long term. There are several reasons for that, among others:

  1. Razor is optimized for HTML generation and a template to generate generating C# code can't be very terse.
  2. Razor templates (in particular ours) tend to contain a lot of logic which can be powerful, but we don't believe that having it inside the template necessarily provides the best experience.

We still want to provide extensibility through some templating language in the future but haven't been able to identify a technology that we can take a dependency on with that purpose in the short term.

We are then going to focus on having a great default experience, e.g. try to get out default generated code as good as possible for EF 7 RTM, while leaving our choice of a template language open.

That implies sacrificing the ability to customize the output code via templates for RTM and it requires either removing the current Razor-based implementation or turning it into an internal implementation detail.

@rowanmiller
Copy link
Contributor

Changing to "remove" rather than "internalize" being an option given #3340

@lajones
Copy link
Contributor

lajones commented Oct 14, 2015

Removed with PR #3393.

@lajones lajones closed this as completed Oct 14, 2015
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-rc1, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Development

No branches or pull requests

4 participants