RevEng: Remove Razor dependency #3393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ved Razor dependency.
| using (_sb.Indent()) | ||
| { | ||
| var shouldAddNewLine = AddEntityFluentApi(fluentApiConfigurations); | ||
| shouldAddNewLine = AddPropertyConfigurations(shouldAddNewLine, propertyConfigurations); |
There was a problem hiding this comment.
Thinking about this some more - will make shouldAddNewLine into member rather than passing it around.
|
|
||
| _sb.AppendLine("public " | ||
| + _cSharpUtilities.GetTypeName(property.ClrType) | ||
| + " " + property.Name + " { get; set; }"); |
There was a problem hiding this comment.
How does this behave when there's default value for the property? or when it's getter only vice versa, etc.
There was a problem hiding this comment.
This is only for reverse engineering. We produce both getter and setter in the generated code. The customer is free to remove the setter once the code has been generated (along with any other changes) if that better suits their model. Default values are assigned via fluent API in the generated DbContext sub-class.
|
|
|
Checked in with commit 1e09fed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2947. Add in a new
CodeWriterbased onIndentedStringBuilderand removeRazorTemplateCodeWriterand its supporting code.