SqlServer: Translate TimeSpan members #19774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bricelam
approved these changes
Feb 2, 2020
roji
reviewed
Feb 3, 2020
test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Feb 5, 2020
src/EFCore.SqlServer/Query/Internal/SqlServerTimeSpanMemberTranslator.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Feb 5, 2020
src/EFCore.SqlServer/Query/Internal/SqlServerTimeSpanMemberTranslator.cs
Outdated
Show resolved
Hide resolved
…imple array initialization in SqlServerTimeSpanMemberTranslator
…the added property Duration
smitpatel
approved these changes
Feb 6, 2020
smitpatel
reviewed
Feb 6, 2020
roji
reviewed
Feb 10, 2020
| @@ -148,6 +148,54 @@ public override async Task Byte_array_filter_by_SequenceEqual(bool async) | |||
| WHERE ""s"".""Banner5"" = @__byteArrayParam_0"); | |||
| } | |||
|
|
|||
| [ConditionalTheory(Skip = "PR #19774")] | |||
| public override Task TimeSpan_Hours(bool async) | |||
There was a problem hiding this comment.
nit: can use expression-bodied method for all these (even on same line if it fits)
There was a problem hiding this comment.
This is done 😉
bricelam
approved these changes
Feb 14, 2020
|
Why didn't Cosmos fail? Is the whole class skipped there? |
Yes. Cosmos does not implement gearsofwar tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to the issue #19632 .
The following translations are enabled:
DATEPART(hour, @timeSpan)DATEPART(minute, @timeSpan)DATEPART(second, @timeSpan)DATEPART(millisecond, @timeSpan)