Keep parameter names for inlined queries #23437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Nov 23, 2020
src/EFCore/Query/Internal/ParameterExtractingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Nov 23, 2020
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindIncludeQuerySqlServerTest.cs
Outdated
Show resolved
Hide resolved
|
Ok, this is ready for review now. Fixes three separate issues, see first comment above. |
|
All good @smitpatel ? Let me know if there is more work to do here. |
smitpatel
reviewed
Dec 4, 2020
src/EFCore/Query/Internal/ParameterExtractingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Dec 4, 2020
src/EFCore/Query/Internal/ParameterExtractingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Dec 4, 2020
smitpatel
force-pushed
the
joakim/keep-parameter-names-for-inlined-queries
branch
from
0313b40
to
ea829ed
Compare
|
Requesting review from @roji / @AndriySvyryd to look over the simple caching mechanism. |
roji
reviewed
Feb 23, 2021
There was a problem hiding this comment.
@smitpatel gave it a look, but probably good to have @AndriySvyryd eyes on it too.
src/EFCore/Query/Internal/ParameterExtractingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
smitpatel
force-pushed
the
joakim/keep-parameter-names-for-inlined-queries
branch
from
ea829ed
to
add1956
Compare
smitpatel
force-pushed
the
joakim/keep-parameter-names-for-inlined-queries
branch
from
add1956
to
74cc390
Compare
|
|
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
smitpatel
approved these changes
Feb 23, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23271
New test
Query_reusing_parameter_with_inner_query_doesnt_declare_duplicate_parameteradded to verify solution.Other tests modified since constants are now kept for lambdas and not reused from earlier top-level expressions.
All tests pass locally.