Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for ASP.NET Core Identity model #23723

Merged
merged 4 commits into from
Dec 19, 2020
Merged

Add testing for ASP.NET Core Identity model #23723

merged 4 commits into from
Dec 19, 2020

Conversation

ajcvickers
Copy link
Member

Fixes #11838

The intention here is not to test ASP.NET Core Identity. It is instead to test that:

  • The Identity model continues to build correctly with new versions of EF Core and across multipler providers, including external providers once they adopt these tests
  • The queries issues by Identity continue to work in new versions and across providers
  • The common (documented) customizations of the Identity model continue to work

@ajcvickers ajcvickers requested a review from a team December 17, 2020 23:01
@smitpatel
Copy link
Member

Can you

@ajcvickers
Copy link
Member Author

@smitpatel Done. (Hope I got it all right!)

</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\src\EFCore.Relational\EFCore.Relational.csproj" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specs test generally don't depend on relational. But identity model would be hard to use with non-relational database (except for inmemory), so may be it is fine to leave this as is. There is also an option to add in the name that this is relational specific, like our relational.specs tests. I don't mind either way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was what I discussed a couple of weeks ago in triage. ASP.NET Identity references the relational package, so even if you use Identity with a non-relational provider (like in-memory) there is still a reference to Relational brought in transitively. The idea here is to make sure we reference our build of Relational, and not just happen to use the one from Identity.

Fixes #11838

The intention here is not to test ASP.NET Core Identity. It is instead to test that:
* The Identity model continues to build correctly with new versions of EF Core and across multipler providers, including external providers once they adopt these tests
* The queries issues by Identity continue to work in new versions and across providers
* The common (documented) customizations of the Identity model continue to work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add EF tests that use the Identity model
2 participants