[5.0.3] Fix to #23617 - IQueryable.All evaluate to false with predicate _ => true #23810
Conversation
|
Description We have optimization for EXISTS, that returns false when the subquery has a predicate which filters out all the rows. In such case we return constant false. However, ExistsExpression also stores information about it being negated or not (i.e. EXISTS vs NOT EXISTS). Customer Impact Basic query: entities.All(x => true) returns incorrect result. The query is not very useful, but it always returns the wrong result. How found Customer reported on 5.0.1. Test coverage We have added test coverage in this PR. Regression? Yes, from 3.1 Risk Low. Fix only affects one codepath which involves small SQL optimization of one particular scenario. Also added quirk to revert to earlier behavior. |
…true We have optimization for EXISTS, that returns false when the subquery has a predicate which filters out all the rows. In such case we return constant false. However, ExistExpression also stores information about it being negated or not (i.e. EXISTS vs NOT EXISTS). If the Exists expression is negated and the predicate filters out all the rows we should return true instead. Fixes #23617
We have optimization for EXISTS, that returns false when the subquery has a predicate which filters out all the rows. In such case we return constant false. However, ExistExpression also stores information about it being negated or not (i.e. EXISTS vs NOT EXISTS).
If the Exists expression is negated and the predicate filters out all the rows we should return true instead.
Fixes #23617