[5.0.3] Fix to #23779 - TryRewriteEntityEquality and NotEqual comparison of CompositePrimaryKey #23836
Conversation
maumar
changed the title
|
Description When comparing composite key entities we were comparing the constituent keys and combining them with AndAlso. For not equal comparison we were still comparing the keys using !=, but we didn't flip the combining operator to OrElse. Customer Impact Data corruption. Queries which compare two entities which have composite key may result incorrect results. How found Customer reported on 5.0.1. Test coverage We have added test coverage in this PR. Regression? No, this scenario was not supported in previous versions. Risk Low. Fix only affects one codepath (per provider) which involves flipping binary operation from AndAlso to OrElse for one particular scenario - comparing two entities with composite keys. Also added quirk to revert to earlier behavior. |
src/EFCore.Relational/Query/RelationalSqlTranslatingExpressionVisitor.cs
Outdated
Show resolved
Hide resolved
…ompositePrimaryKey When comparing composite key entities we were comparing the constituent keys and combining them with AndAlso. For not equal comparison we were still comparing the keys using !=, but we didn't flip the combining operator to OrElse. Fixes #23779
When comparing composite key entities we were comparing the constituent keys and combining them with AndAlso. For not equal comparison we were still comparing the keys using !=, but we didn't flip the combining operator to OrElse.
Fixes #23779