More nullable annotations #23938
More nullable annotations #23938
Conversation
src/EFCore.Cosmos/Infrastructure/Internal/CosmosDbOptionExtension.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Diagnostics/RelationalLoggerExtensions.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/EntityFrameworkRelationalServicesBuilder.cs
Show resolved
Hide resolved
src/EFCore.InMemory/Infrastructure/Internal/InMemoryOptionsExtension.cs
Outdated
Show resolved
Hide resolved
src/EFCore.Relational/Infrastructure/RelationalOptionsExtension.cs
Outdated
Show resolved
Hide resolved
* Infrastructure * Diagnostics * Proxies * Abstractions * Analyzers Part of #19007
roji
force-pushed
the
InfrastructureNullability
branch
from
dfb8b3e
to
26136d0
Compare
|
Hello @roji! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
ghost
merged commit 
* Infrastructure * Diagnostics * Proxies * Abstractions * Analyzers Part of dotnet#19007
| @@ -1713,7 +1715,7 @@ private static string MultipleNavigationProperties(EventDefinitionBase definitio | |||
| /// <param name="targetType"> The target type. </param> | |||
| public static void MultipleInversePropertiesSameTargetWarning( | |||
| [NotNull] this IDiagnosticsLogger<DbLoggerCategory.Model> diagnostics, | |||
| [NotNull] IEnumerable<Tuple<MemberInfo, Type>> conflictingNavigations, | |||
| [NotNull] IEnumerable<Tuple<MemberInfo?, Type>> conflictingNavigations, | |||
There was a problem hiding this comment.
@roji I'm getting a nullable warning when I build locally from command-line on line 1728 which indeed dereferences a possible null reference (n.Item1.Name).
Do you know why/how this didn't fail CI?
There was a problem hiding this comment.
We purposefully don't (currently!) fail the build on nullability warnings (<WarningsNotAsErrors>nullable</WarningsNotAsErrors>), to not hold people back until we're done. The plan is to reenable those as errors when we complete the annotation process.
I know it looks huge, but this one is actually easy. Starting to see the end of the tunnel...
This annotates the following for nullability:
@ajcvickers there have been various tweaks in the logging/interception, probably worth taking a look. As usual I'll self-review this PR to highlight places where I'd appreciate some attention.