Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default options on ToDebugString #24498

Merged
merged 2 commits into from
Mar 24, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/ICheckConstraint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public interface ICheckConstraint : IReadOnlyCheckConstraint, IAnnotatable
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IColumn.cs
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public virtual string? Collation
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IColumnMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public interface IColumnMapping : IColumnMappingBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IForeignKeyConstraint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public interface IForeignKeyConstraint : IAnnotatable
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IFunctionColumn.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public interface IFunctionColumn : IColumnBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IFunctionColumnMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public interface IFunctionColumnMapping : IColumnMappingBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IFunctionMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public interface IFunctionMapping : ITableMappingBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IReadOnlyDbFunction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public interface IReadOnlyDbFunction : IReadOnlyAnnotatable
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public interface IReadOnlyDbFunctionParameter : IReadOnlyAnnotatable
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IReadOnlySequence.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public interface IReadOnlySequence : IReadOnlyAnnotatable
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IRelationalModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ IEnumerable<ISequence> Sequences
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/ISqlQuery.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public interface ISqlQuery : ITableBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/ISqlQueryColumn.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public interface ISqlQueryColumn : IColumnBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/ISqlQueryColumnMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public interface ISqlQueryColumnMapping : IColumnMappingBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/ISqlQueryMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public interface ISqlQueryMapping : ITableMappingBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IStoreFunction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public interface IStoreFunction : ITableBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IStoreFunctionParameter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ public interface IStoreFunctionParameter : IAnnotatable
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/ITable.cs
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public virtual string? Comment
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/ITableIndex.cs
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public interface ITableIndex : IAnnotatable
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/ITableMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public interface ITableMapping : ITableMappingBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IUniqueConstraint.cs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ bool GetIsPrimaryKey()
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IView.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public interface IView : ITableBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IViewColumn.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public interface IViewColumn : IColumnBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IViewColumnMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public interface IViewColumnMapping : IColumnMappingBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Relational/Metadata/IViewMapping.cs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public interface IViewMapping : ITableMappingBase
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore/ChangeTracking/ChangeTrackerExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ public static class ChangeTrackerExtensions
/// <returns> A human-readable representation. </returns>
public static string ToDebugString(
this ChangeTracker changeTracker,
ChangeTrackerDebugStringOptions options,
ChangeTrackerDebugStringOptions options = ChangeTrackerDebugStringOptions.LongDefault,
int indent = 0)
{
var builder = new StringBuilder();
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore/Metadata/IReadOnlyEntityType.cs
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,7 @@ IReadOnlyProperty GetProperty(string name)
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore/Metadata/IReadOnlyForeignKey.cs
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ bool IsBaseLinking()
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore/Metadata/IReadOnlyIndex.cs
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public interface IReadOnlyIndex : IReadOnlyAnnotatable
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore/Metadata/IReadOnlyKey.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ bool IsPrimaryKey()
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore/Metadata/IReadOnlyModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ private static int GetDerivedLevel(Type? derivedType, Dictionary<Type, int> deri
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore/Metadata/IReadOnlyNavigation.cs
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ bool IReadOnlyNavigationBase.IsCollection
/// <param name="options"> Options for generating the string. </param>
/// <param name="indent"> The number of indent spaces to use before each new line. </param>
/// <returns> A human-readable representation. </returns>
string ToDebugString(MetadataDebugStringOptions options, int indent = 0)
string ToDebugString(MetadataDebugStringOptions options = MetadataDebugStringOptions.ShortDefault, int indent = 0)
{
var builder = new StringBuilder();
var indentString = new string(' ', indent);
Expand Down
Loading