14205 sql server translate bool to string #24793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulling last changes
- Adding boolean.ToString translation via CASE WHEN END
- Adding test to cover a new feature
Fixes dotnet#14205
|
|
maumar
reviewed
Apr 28, 2021
MaxG117
reviewed
Apr 29, 2021
src/EFCore.SqlServer/Query/Internal/SqlServerObjectToStringTranslator.cs
Show resolved
Hide resolved
|
@smitpatel: all suggestions are resolved, could you please have a look at a spare moment? |
maumar
approved these changes
May 5, 2021
|
@michalczerwinski thank you for the contribution! |
Glad I could help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now ToString on boolean column and nullable boolean column is translated into CASE WHEN and returns 'true', 'false' or null.
Added 2 tests covering both scenario.