Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to Microsoft.Data.SqlClient 2.x #25057

Merged
1 commit merged into from
Jun 14, 2021
Merged

Revert to Microsoft.Data.SqlClient 2.x #25057

1 commit merged into from
Jun 14, 2021

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Jun 8, 2021

No description provided.

@bricelam bricelam requested a review from a team June 8, 2021 19:22
.github/dependabot.yml Outdated Show resolved Hide resolved
@ErikEJ
Copy link
Contributor

ErikEJ commented Jun 8, 2021

Why?

@bricelam
Copy link
Contributor Author

bricelam commented Jun 8, 2021

Can't release an LTS of EF Core that depends on a non-LTS of SqlClient ☹

@bricelam bricelam changed the title Revert to Microsoft.Data.SqlClient 2.1.x Revert to Microsoft.Data.SqlClient 2.x Jun 8, 2021
@bricelam
Copy link
Contributor Author

bricelam commented Jun 8, 2021

dotnet/SqlClient#1103

@bricelam
Copy link
Contributor Author

Further explanation: We don’t want to put customers in a position where most of their app has long-term support from Microsoft under the .NET 6.0 support policy, but their support policy for the SqlClient assembly has expired.

@ghost
Copy link

ghost commented Jun 14, 2021

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jun 14, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit 24e5c6c into dotnet:main Jun 14, 2021
@bricelam bricelam deleted the downer branch June 14, 2021 18:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants