Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Apache to MIT license #25281

Merged
merged 2 commits into from
Jul 23, 2021
Merged

Switch from Apache to MIT license #25281

merged 2 commits into from
Jul 23, 2021

Conversation

Pilchie
Copy link
Member

@Pilchie Pilchie commented Jul 17, 2021

Fixes #19844.

@Pilchie Pilchie requested a review from ajcvickers July 17, 2021 02:07
@Pilchie
Copy link
Member Author

Pilchie commented Jul 17, 2021

Tagging @richlander @ChrisSfanos @sharwell.

I suggest reviewing commit-by-commit, but skipping the second one. I'll squash at the time when I merge, but no one wants to look at 3700 file headers ;)

@ajcvickers
Copy link
Member

@Pilchie I'm hesitant to sign-off on StyleCop changes without @bricelam taking a look. We have historically done the license through the R# settings, which get applied when we run code cleanup.

@bricelam
Copy link
Contributor

LGTM

ajcvickers
ajcvickers approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 🇮🇹

@Pilchie
Update license to MIT
c6bf803 
Configure StyleCop to run for all projects, and update config to use new
license header.
@Pilchie
Fix all in VS, and update .tt files
435a5e7
@Pilchie Pilchie merged commit 9ac01d6 into main Jul 23, 2021
@Pilchie Pilchie deleted the mit-license branch July 23, 2021 03:14
@ajcvickers ajcvickers mentioned this pull request Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopt MIT license
3 participants
@Pilchie @ajcvickers @bricelam