Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IColumnModification and IModificationCommand to allow the implementations to be replaced easily #25327

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

AndriySvyryd
Copy link
Member

Fixes #23027
Fixes #12169
Fixes #17946

Co-authored-by: Kovalenko Dmitry dmitry.lipetsk@gmail.com

@dmitry-lipetsk
Copy link
Contributor

Hello @AndriySvyryd

Tested. Is ok. Thanks.

@AndriySvyryd AndriySvyryd force-pushed the Issue23027 branch 5 times, most recently from 1c02b4d to 94eaea9 Compare July 26, 2021 19:56
…ntations to be replaced easily

Fixes #23027
Fixes #12169
Fixes #17946

Co-authored-by: Kovalenko Dmitry <dmitry.lipetsk@gmail.com>
@ghost
Copy link

ghost commented Jul 27, 2021

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jul 27, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@dmitry-lipetsk
Copy link
Contributor

Hello EFCore team,

Provider, uses this feature, was released
https://github.com/ibprovider/Lcpi.EFCore.LcpiOleDb-v06.00

Thanks for IColumnModification and the help with other issues.

Отдельное спасибо Андрею.

Dmitry Kovalenko.

Copy link

@s0fire s0fire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lock in view;at home designation on my, prioritize switched on over for a seperate and occasional MERGE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants