Addressing API Review feedback for temporal tables feature: #25430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maumar
commented
Aug 5, 2021
maumar
commented
- converted QueryRootCreator into general purpose helper service,
- renamed WithHistoryTable to UseHistoryTable,
- removed Temporal from entity type extensions,
- added dependency objects to temporal convention.
maumar
commented
Aug 5, 2021
| @@ -6,21 +6,21 @@ | |||
| namespace Microsoft.EntityFrameworkCore.Query | |||
| { | |||
| /// <inheritdoc/> | |||
| public class QueryRootCreator : IQueryRootCreator | |||
| public class NavigationExpansionExtensibilityHelper : INavigationExpansionExtensibilityHelper | |||
There was a problem hiding this comment.
NavigationExpansionExtensibilityService? (or something else?)
There was a problem hiding this comment.
INavigationExpansionHandler?
There was a problem hiding this comment.
wouldn't handler imply too much? this thing only aids the nav expansion in slight ways. the nav expansion proper is "handled" by the nav expanding expression visitor
maumar
force-pushed
the
maumar_api_review
branch
from
233ce40
to
4202dc4
Compare
AndriySvyryd
approved these changes
Aug 5, 2021
maumar
force-pushed
the
maumar_api_review
branch
from
4202dc4
to
8e1ee4a
Compare
- converted QueryRootCreator into general purpose helper service, - renamed WithHistoryTable to UseHistoryTable, - removed Temporal from entity type extensions, - added dependency objects to temporal convention.
maumar
force-pushed
the
maumar_api_review
branch
from
8e1ee4a
to
ccd7d07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.