Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compiled model and runtime initialization thread-safe #25559

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Make compiled model and runtime initialization thread-safe #25559

merged 1 commit into from
Aug 18, 2021

Conversation

AndriySvyryd
Copy link
Member

Fixes #25205

@AndriySvyryd AndriySvyryd requested a review from a team August 17, 2021 21:18
@AndriySvyryd AndriySvyryd changed the base branch from main to release/6.0 August 18, 2021 00:49
@ajcvickers
Copy link
Member

@AndriySvyryd Should this go into rc1?

@AndriySvyryd
Copy link
Member Author

It doesn't have to. Do you think it should?

@ajcvickers
Copy link
Member

I'm on the fence. It fixes an issue with a new feature, but it's not something that most people will hit. I'll leave it up to you.

@AndriySvyryd
Copy link
Member Author

There's no API change and the workaround isn't terrible, so RC2

@AndriySvyryd AndriySvyryd merged commit f8ef489 into release/6.0 Aug 18, 2021
@AndriySvyryd AndriySvyryd deleted the Issue25205 branch August 18, 2021 20:34
@ajcvickers ajcvickers mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AndriySvyryd @ajcvickers