Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct FromSqlRaw docs #25568

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Correct FromSqlRaw docs #25568

merged 1 commit into from
Aug 18, 2021

Conversation

roji
Copy link
Member

@roji roji commented Aug 18, 2021

And simplify the SQL a bit.

Fixes #25567

@roji roji requested a review from a team August 18, 2021 11:51
@ajcvickers
Copy link
Member

Retarget to release/6.0

@roji roji changed the base branch from main to release/6.0 August 18, 2021 12:15
@ghost
Copy link

ghost commented Aug 18, 2021

Hello @roji!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@roji roji changed the title Correctly FromSqlRaw docs Correct FromSqlRaw docs Aug 18, 2021
@ghost
Copy link

ghost commented Aug 18, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost
Copy link

ghost commented Aug 18, 2021

Apologies, while this PR appears ready to be merged, it looks like release/6.0 is a protected branch and I have not been granted permission to perform the merge.

@roji roji merged commit df1fd07 into release/6.0 Aug 18, 2021
@roji roji deleted the roji/FromSqlDocs branch August 18, 2021 13:18
@roji
Copy link
Member Author

roji commented Aug 18, 2021

@ajcvickers note msftbot being denied access above...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FromSqlRaw() - inconsistent/incorrect documentation
2 participants