Cosmos: Don't map collections as owned types #25827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Sep 1, 2021
| @@ -40,6 +40,6 @@ public CosmosRelationshipDiscoveryConvention(ProviderConventionSetBuilderDepende | |||
| /// <param name="model"> The model. </param> | |||
| /// <returns> <see langword="true"/> if the given entity type should be owned. </returns> | |||
| public static bool ShouldBeOwnedType(Type targetType, IConventionModel model) | |||
| => !targetType.IsGenericType || targetType.GetGenericTypeDefinition() != typeof(List<>); | |||
| => !targetType.IsGenericType || targetType.GetInterface("IEnumerable`1") == null; | |||
There was a problem hiding this comment.
I can use GetInterface(typeof(IEnumerable<>).Name), but there's no Type overload for some reason
AndriySvyryd
force-pushed
the
Issue25749
branch
from
09bef5a
to
d0d501b
Compare
AndriySvyryd
force-pushed
the
Issue25749
branch
from
d0d501b
to
f18729f
Compare
smitpatel
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reenable test for #24684
Fixes #25749
Fixes #24684