Adding regression tests for some issues fixed earlier #25835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
commented
Sep 2, 2021
| @@ -33,7 +33,20 @@ public override void Entity_mapped_to_view_on_right_side_of_join() | |||
|
|
|||
| public override async Task KeylessEntity_with_included_nav(bool async) | |||
| { | |||
| await Assert.ThrowsAsync<InvalidOperationException>(() => base.KeylessEntity_with_included_nav(async)); | |||
| await Assert.ThrowsAsync<InvalidOperationException>( | |||
There was a problem hiding this comment.
should we just move those tests to relational? currently we throw obsolete IncludeOnEntityWithDefiningQueryNotSupported exception for InMemory here
There was a problem hiding this comment.
not yet, let's wait till new defining query implementation. It may end up working.
maumar
force-pushed
the
moar_verify
branch
3 times, most recently
from
aee788e
to
1781f85
Compare
|
Hello @maumar! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Apologies, while this PR appears ready to be merged, it looks like |
smitpatel
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13560
Resolves #17364
Resolves #17803
Resolves #21078
Resolves #21828
Resolves #23041