Preserve extension registration order #26132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
changed the title
|
@Pilchie For approval |
ajcvickers
reviewed
Sep 22, 2021
ajcvickers
approved these changes
Sep 22, 2021
AndriySvyryd
force-pushed
the
Issue26071
branch
from
eb29ef3
to
3521149
Compare
|
Approved for EFCore 6.0 |
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26071
Description
The extension services are applied in alphabetic order instead of the order in which they were added.
The fix requires breaking some protected API on
DbContextOptions, but this class is designed to use composition, not inheritance, so it shouldn't affect any external code.Customer impact
Extensions that depend on a provider being registered will throw errors if they happen to be sorted before the provider.
How found
Customer
Regression
Yes, introduced in rc1 by 4e3ce4e
Testing
Test for this scenario added in the PR.
Risk
Low, this reverts the behavior to pre-rc1.