[6.0] Flag all properties as not unknown when saving changes #26346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26330
Description
When saving changes to the database for an entity with a potentially unknown key value, that key value remained marked as unknown after saving if the property uses a value generator that does not generate temporary values.
Customer impact
Exception thrown when saving changes with the in-memory provider using owned collections, but also fails with other providers when using value generators that do not generate temporary values.
How found
Multiple customer reports on RC2.
Regression
Yes, from 5.0.
Testing
Test for this scenario added in the PR which runs for multiple providers and value generators.
Risk
Low; the fix is to clear the unknown flag when accepting saved changes into the state manager.