Configure the correct end as principal for self-ref collection with [ForeignKey] #26372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
commented
Oct 15, 2021
ajcvickers
approved these changes
Oct 16, 2021
AndriySvyryd
force-pushed
the
Issue26364
branch
from
eff4df2
to
1b26dd5
Compare
…ForeignKey] Fixes #26364
AndriySvyryd
force-pushed
the
Issue26364
branch
from
1b26dd5
to
65577ca
Compare
AndriySvyryd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26364
Description
Using
[ForeignKey]on a self-ref collection navigation results in an exception during model building.Customer impact
The exception is thrown from a convention that runs before Fluent API configuration. The only reasonable workaround is to remove the
[ForeignKey].How found
Multiple customer reports on RC2.
Regression
Yes, from 6.0 RC1, introduced in #25806
Testing
Test for this scenario added in the PR.
Risk
Low, the changed code only affects self-ref navigations with
[ForeignKey].