[6.0.1] Query: Copy client projections when updating SelectExpression #26431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
approved these changes
Oct 22, 2021
smitpatel
changed the title
|
@smitpatel Quirk? |
|
@ajcvickers - On my radar, will add soon. |
|
Updated with quirk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26428
Description
An exception is thrown when running query which has value converters used for predicate.
Customer impact
Query which could work will not work and throw exception.
How found
Customer report on RC2.
Regression
Yes, from EF Core 5.0
Testing
Test for this scenario added in the PR. Other tests verifies that change is not generating something incorrect.
Risk
Low; the fix is to update SelectExpression through Update method correctly.