Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and fix for Issue #26742 #26758

Merged
merged 3 commits into from
Dec 6, 2021
Merged

Conversation

EamonHetherton
Copy link
Contributor

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #26742
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, but looks like BuiltInDataTypesSqlServerTest are failing. Consider running all the tests locally to see which are failing. See https://github.com/dotnet/efcore/blob/main/docs/getting-and-building-the-code.md
Probably no need to install the Cosmos Emulator for this PR.

@ajcvickers
Copy link
Member

@EamonHetherton Can you rebase this against main and resolve conflicts?

@ajcvickers ajcvickers merged commit 9db26bd into dotnet:main Dec 6, 2021
@ajcvickers
Copy link
Member

Thanks!

@ajcvickers ajcvickers changed the title test and fix for Issue #26742 Test and fix for Issue #26742 Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants