Automatic refactorings based on static analysis of EFCore project #26806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Nov 25, 2021
|
@roji I would rather we could just say yes/no to each of these changes, rather than suggesting other changes instead. I'm reluctant to mix these changes with manual code changes that seem correct. I think that should be done in a separate PR. |
Mostly completely automatic; a few manual tweaks. Part of #26805
ajcvickers
force-pushed
the
InspectorLewis1123
branch
from
0b166bc
to
3ad858b
Compare
Merged
|
Submitted #26904 for the manual improvements proposed above. |
roji
added a commit
that referenced
this pull request
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly completely automatic; a few manual tweaks.
Part of #26805