Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static analysis: remove trailing commas #26906

Merged
merged 1 commit into from
Dec 6, 2021
Merged

Conversation

ajcvickers
Copy link
Member

Part of #26805

@ajcvickers ajcvickers requested a review from a team December 6, 2021 12:42
@ajcvickers ajcvickers merged commit bfd6f04 into main Dec 6, 2021
@ajcvickers ajcvickers deleted the InspectorBarnaby1206 branch December 6, 2021 16:53
@sharwell
Copy link
Member

sharwell commented Dec 6, 2021

This change has the negative side effect of reducing the effectiveness of git blame and increasing code churn. See also SA1413 Use trailing comma in multi-line initializers and DotNetAnalyzers/StyleCopAnalyzers#2884. I would strongly encourage reporting a bug to the authors of the tool that led to this analysis warning with a request that the rule be eliminated or corrected.

@ajcvickers
Copy link
Member Author

At this point, the cleanup is just about being consistent. We decided this so long ago that I don't remember much about the discussion. It's easy to go the other way if people on the team feel like we should.

/cc @dotnet/efteam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants