Static analysis: inconsistent naming and namespaces #26919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
reviewed
Dec 7, 2021
| @@ -13,7 +13,7 @@ namespace Microsoft.EntityFrameworkCore; | |||
| public sealed class InternalUsageDiagnosticAnalyzer : DiagnosticAnalyzer | |||
| { | |||
| public const string Id = "EF1001"; | |||
| private static readonly int EFLen = "EntityFrameworkCore".Length; | |||
| private static readonly int _efLen = "EntityFrameworkCore".Length; | |||
There was a problem hiding this comment.
This should follow the same convention as private const
AndriySvyryd
approved these changes
Dec 7, 2021
…ention for const fields.
ajcvickers
force-pushed
the
InspectorMeadows1207
branch
from
2813548
to
329663f
Compare
|
@dotnet/efteam Updated to make private read-only static fields match the naming convention for const fields. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #26805