[6.0.2] Query: Avoid stackoverflow in lifting group by aggregate term #27131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Jan 6, 2022
smitpatel
force-pushed
the
smit/brightandsunny
branch
from
88c1896
to
a21898b
Compare
smitpatel
force-pushed
the
smit/snowisbad
branch
from
5a89f0a
to
95b291d
Compare
Correlate the scalar subquery with parent SelectExpression Resolves #27094
smitpatel
force-pushed
the
smit/brightandsunny
branch
from
a21898b
to
3dd11db
Compare
ajcvickers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correlate the scalar subquery with parent SelectExpression
Resolves #27094
Description
Certain queries with group by aggregate on multiple level generates stackoverflow exception.
Customer impact
Program crashes with stackoverflow exception.
How found
Customer reported on 6.0.1
Regression
Yes. Query used to work in 5.0 version.
Testing
Added test for customer scenario and similar variations.
Risk
Low risk. Also added quirk mode.