Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Microsoft.AspNetCore.OData from 8.0.4 to 8.0.6 #27178

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 12, 2022

Bumps Microsoft.AspNetCore.OData from 8.0.4 to 8.0.6.

Release notes

Sourced from Microsoft.AspNetCore.OData's releases.

ASP.NET Core OData 8.0.6

https://www.nuget.org/packages/Microsoft.AspNetCore.OData/8.0.6

  • Make TryGetNestedPropertyValue internal
  • Fix 'none OData' -> 'non-OData' typo

ASP.NET Core OData 8.0.5

https://www.nuget.org/packages/Microsoft.AspNetCore.OData/8.0.5

What's Changed

Be noted: TryGetNestedPropertyValue has been added accidentally as public, it will be internal in the next version. Please use TryGetPropertyValue except TryGetNestedPropertyValue.

New Contributors

Full Changelog: OData/AspNetCoreOData@8.0.4...8.0.5

Commits
  • 2edd04d Update the release version to 8.0.6
  • 176108a internal TryGetNestedPropertyValue in DeltaOfT
  • f18c7ac ✏️ Fix 'none OData' -> 'non-OData' typo
  • c6ed979 Add TryGetNestedPropertyValue in DeltaOfT
  • ed424ce Add a scenario about how to patch complex property
  • 5407ca3 Update the model builder dependency to 1.0.8
  • f9e6c79 Update README.md
  • 89271ba Swith to use main as default branch name
  • 69eec03 update the release version to 8.0.5
  • ccffcf4 Enable dollar search ($search) interface
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [Microsoft.AspNetCore.OData](https://github.com/OData/AspNetCoreOData) from 8.0.4 to 8.0.6.
- [Release notes](https://github.com/OData/AspNetCoreOData/releases)
- [Commits](OData/AspNetCoreOData@8.0.4...8.0.6)

---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.OData
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dougbu
Copy link
Member

dougbu commented Jan 13, 2022

@smitpatel I thought we moved away from Ubuntu 16.04 but this PR failed a lot of tests on (Ubuntu.1804.Amd64.SqlServer)Ubuntu.1604.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-sqlserver-amd64-2020110918-3069967. The Helix queue there is Ubuntu.1604.Amd64.Open.

The particular PR may pass on retry (going now) but the general issue will remain. That Helix queue isn't yet slated for removal, but we should expect that soon.

There's also a new 20211215184933-3069967 version of the Docker image.

@dougbu
Copy link
Member

dougbu commented Jan 19, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@smitpatel
Copy link
Member

Submitted PR for the fix.

What would be recommended ubuntu machine to use? We need docker on it and when we updated others we still didn't have docker enabled ubuntu image better than 1604

@dougbu
Copy link
Member

dougbu commented Jan 19, 2022

@smitpatel Ubuntu.1804.Amd64.Open has Docker and a very long life ahead of it. So, I'd recommend either

  • (Ubuntu.1804.Amd64.SqlServer)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-sqlserver-amd64-2020110918-3069967 (keeping the same version of the Docker image)
  • (Ubuntu.1804.Amd64.SqlServer)Ubuntu.1804.Amd64.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-helix-sqlserver-amd64-20211215184933-3069967 (using the newer Docker image)

On second thought, I bet this isn't truly related to this PR. More likely the PR was opened when something general was wrong e.g. dotnet/efcore might have needed the 22ff162 or 7880099 fix. That doesn't make your PR less interesting @smitpatel, just less urgent.

@dougbu
Copy link
Member

dougbu commented Jan 19, 2022

OIC #27219 might be needed to get this PR building given the typo in 7880099. Updating the Helix queue is separate.

@dougbu dougbu merged commit 3e8114e into main Jan 19, 2022
@dougbu dougbu deleted the dependabot/nuget/Microsoft.AspNetCore.OData-8.0.6 branch January 19, 2022 20:41
@dougbu
Copy link
Member

dougbu commented Jan 19, 2022

Nope, #27219 wasn't needed to get this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants