[6.0.x] Reset read count on RelationalDataReader #27852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#27652 (cherry picked from commit 1b9becc)
ajcvickers
approved these changes
Apr 21, 2022
|
@ajcvickers Are these ready to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the EF Core 6.0 query perf optimization cycle, RelationalDataReader started to get recycled across executions, but the read count value wasn't properly reset.
Customer impact
When tracking how many reader reads were performed via DataReaderDisposingEventData.ReadCount, users got incorrect values since the count wasn't properly reset across usages of RelationalDataReader. No known workaround.
How found
Customer reported on 6.0.
Regression
Yes, From 5.0.
Testing
Added test.
Risk
Very low risk, one-line fix.
Backports #27845
Fixes #27652