Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some NuGet packages #28090

Merged
merged 1 commit into from
May 31, 2022
Merged

Update some NuGet packages #28090

merged 1 commit into from
May 31, 2022

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented May 24, 2022

Changes:

  • Remove obsolete Microsoft.CodeAnalysis.FxCopAnalyzers package
  • Bump SQLitePCLRaw to 2.1.0
  • Bump AspNetCore.Identity to 6.0.5
  • Bump Grpc to 2.46.0

@bricelam bricelam requested a review from a team May 24, 2022 18:51
@bricelam bricelam requested a review from dougbu as a code owner May 24, 2022 18:51
@@ -27,7 +27,6 @@ updates:
- dependency-name: Microsoft.CodeAnalysis.CSharp*
# New analyzer rules would need to be disabled
- dependency-name: DotNetAnalyzers.DocumentationAnalyzers
- dependency-name: Microsoft.CodeAnalysis.FxCopAnalyzers
Copy link
Contributor Author

@bricelam bricelam May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, all the CA#### rules are still enabled--they're built into the SDK now.

@ghost
Copy link

ghost commented May 24, 2022

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

eng/Versions.props Outdated Show resolved Hide resolved
@dougbu
Copy link
Member

dougbu commented May 24, 2022

Suggest asking in First Responders channel for the missing packages to be added to the dotnet-public feed

@ghost
Copy link

ghost commented May 31, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

Changes:
- Remove obsolete Microsoft.CodeAnalysis.FxCopAnalyzers package
- Bump SQLitePCLRaw to 2.1.0
- Bump AspNetCore.Identity to 6.0.5
- Bump Grpc to 2.45.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants