[release/3.1] Tools: Enable .NET Framework projects targeting win-arm64 #28254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Jun 16, 2022
|
Hmm... I don't think you can actually run dotnet-ef 3.1 on win-arm64. We don't have a rollforward behavior defined, so it requires the 3.1 runtime. But installing the 3.1 (x64) runtime errors with not supported by the processor type. |
|
Ok, I can work around is using this. SET DOTNET_ROLL_FORWARD=Major |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ARM64 build of the .NET Framework "inside man" ef.exe. Also adds a win-arm64 shim to dotnet-ef for signing.
Customer impact
Without this, dotnet-ef and the PMC commands won't work with .NET Framework projects specifically targeting ARM64. It's worth noting, however, that AnyCPU, x86, and x64 projects will work on ARM64 machines without this change.
Regression
No. ARM64 has not previously been supported on .NET Framework with the EF tools.
Risk
Low.
This just adds a new code branch and assembly that will only run when the project targets ARM64. Previously, this condition would have resulted in the following error.
Verification
Manual verification pending. How do I requisition one of those fancy new Project Volterra devices? 😜