Fix scaffolding of reference navigations with NRT (#27616) #28382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#27496 (cherry picked from commit ec9c6c2)
|
Never mind; design-time only. |
ajcvickers
approved these changes
Jul 7, 2022
|
Blocked until the branch opens again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27496
(cherry picked from commit ec9c6c2)
Description
When scaffolding an existing database in a project with nullable reference types enabled, dependent navigations are incorrectly scaffolded as non-nullable.
Customer impact
An incorrect model is scaffolded and must be manually fixed up.
How found
Customer reported on 6.0
Regression
No, scaffolding NRT code was introduced in 6.0 (#15520)
Testing
Added.
Risk
Low - affects design-time scaffolding only.