Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SqlQuery<T> #28665

Merged
1 commit merged into from
Aug 15, 2022
Merged

Implement SqlQuery<T> #28665

1 commit merged into from
Aug 15, 2022

Conversation

smitpatel
Copy link
Member

Resolves #11624

@smitpatel smitpatel requested a review from a team August 11, 2022 01:55
@smitpatel smitpatel marked this pull request as draft August 11, 2022 05:27
@smitpatel
Copy link
Member Author

Converting to draft. I don't like RawSqlQueryExpression

@smitpatel
Copy link
Member Author

blocked on #28667

@smitpatel smitpatel marked this pull request as ready for review August 13, 2022 23:38
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smitpatel here are some suggestions!

@roji roji dismissed their stale review August 14, 2022 20:40

Approved by mistake

@smitpatel smitpatel requested review from roji and a team August 15, 2022 17:16
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits, 🐑 🇮🇹

@ghost
Copy link

ghost commented Aug 15, 2022

Hello @smitpatel!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Aug 15, 2022

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. Azure Pipelines

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost ghost merged commit 446be9a into main Aug 15, 2022
@ghost ghost deleted the smit/scalarquery_2 branch August 15, 2022 20:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support raw SQL Queries for basic types like Guid, DateTime and int
2 participants