Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform structural equality in ExpressionEqualityComparer #28720

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Perform structural equality in ExpressionEqualityComparer #28720

merged 1 commit into from
Sep 7, 2022

Conversation

roji
Copy link
Member

@roji roji commented Aug 15, 2022

Fixes #28581

@roji roji requested a review from a team August 15, 2022 14:15
smitpatel
smitpatel previously requested changes Aug 15, 2022
View reviewed changes
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs-design

@roji roji dismissed smitpatel’s stale review September 7, 2022 07:16

Team has decided to go ahead with this.

@roji roji requested a review from dougbu as a code owner September 7, 2022 07:19
@roji roji changed the base branch from main to release/7.0 September 7, 2022 07:19
@roji roji mentioned this pull request Sep 7, 2022
Open
@roji roji merged commit 3255316 into dotnet:release/7.0 Sep 7, 2022
@roji roji deleted the ArrayComparisons branch September 7, 2022 09:38
@ajcvickers ajcvickers mentioned this pull request Sep 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@smitpatel smitpatel smitpatel left review comments

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linq expression containing Array Object isn't cached and compiled every time
3 participants
@roji @smitpatel @AndriySvyryd