Generate condition for required property in optional dependents #29206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29142
Description
Same area as fix #29207, but this time when using entity equality.
When a dependent entity shares a table with its principal but does not have any required properties, then the meaning of all all dependent columns being null is ambiguous. It could mean that the entity does not exist, or it could mean that the entity exists but all its properties have null values. We therefore warn about this kind of mapping and recommend against it. Nevertheless, it is still used by customers, and in EF7 we broke cases where this is used with entity equality. This change reverts those breaks.
Customer impact
Customers using optional owned dependents with table splitting and no required properties will get exceptions using entity equality.
How found
Customer reported on EF7 RC1.
Regression
Yes, from 6.0.
Testing
Regression tests added.
Risk
Low; reverts back to the EF Core 6.0 code.