[release/7.0] Use correct parameter in query based on type mapping #29724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#29646 (cherry picked from commit 3f82c2b)
AndriySvyryd
approved these changes
Dec 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29646, backports #29650
Description
When the same parameter is used in a query in contexts which require different type mappings, we sometimes use the incorrect type mapping in the incorrect context.
Customer impact
Since the incorrect SQL representation or parameter may be sent to the server, LINQ queries may return incorrect data. For example, if the same .NET string is compared against both Unicode and non-Unicode database columns in a query, that could yield wrong results.
How found
Customer reported on 7.0
Regression
Yes.
Testing
Added a test for the affected scenario.
Risk
Low; the fix is quite trivial, and a quirk was added to revert back to older behavior.