Handle row-version columns in owned types with conversions #29730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
commented
Dec 1, 2022
test/EFCore.SqlServer.FunctionalTests/OptimisticConcurrencySqlServerTest.cs
Outdated
Show resolved
Hide resolved
ajcvickers
commented
Dec 1, 2022
| } | ||
| else | ||
| { | ||
| await context.SaveChangesAsync(); |
There was a problem hiding this comment.
@AndriySvyryd For TPT when the owned entity is updated, there is no DbUpdateConcurrencyException
ajcvickers
commented
Dec 1, 2022
test/EFCore.SqlServer.FunctionalTests/OptimisticConcurrencySqlServerTest.cs
Show resolved
Hide resolved
|
@AndriySvyryd I have made three comments which might indicate additional bugs, either known or not. |
AndriySvyryd
reviewed
Dec 1, 2022
src/EFCore.Relational/Metadata/Conventions/TableSharingConcurrencyTokenConvention.cs
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Dec 1, 2022
This was referenced Dec 3, 2022
Fixes #29689 Also add more end-to-end tests for optimistic concurrency, converters, owned types, inheritance, and table sharing.
ajcvickers
force-pushed
the
LongButNotTooLong1128
branch
from
f10256a
to
0de13fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29689
Also add more end-to-end tests for optimistic concurrency, converters, owned types, inheritance, and table sharing.