Use OUTPUT INTO for generated values in SqlServer to support tables with triggers #3869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| commandStringBuilder | ||
| .Append($"DECLARE @generated{commandPosition} TABLE (") | ||
| .AppendJoin(readOperations.Select(c => | ||
| $"{SqlGenerator.DelimitIdentifier(c.ColumnName)} {GetTypeNameForCopy(c.Property)}")) |
There was a problem hiding this comment.
Beware that @bricelam hates this 😄
There was a problem hiding this comment.
Yes, I do. Concatenation is cheaper.
There was a problem hiding this comment.
Everywhere in this file or just this instance?
|
Did you think about adding actual triggers to some tables in the functional tests? |
|
I had a few questions but this looks Not removing the "needs-review" tag in case you want to get another pair of eyes on it. |
provided that you give me satisfactory answers 😄
|
I'll try to add FTs with triggers, but it might take some time. |
Ok, can you file a bug on that and then |
…ith triggers Add commandPosition argument to methods on IUpdateSqlGenerator to provide a unique id for a modification command in a batch Fixes #1441
AndriySvyryd
force-pushed
the
OutputTable
branch
from
611d903
to
2627626
Compare
|
Added FTs |
|
Neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add commandPosition argument to methods on IUpdateSqlGenerator to provide a unique id for a modification command in a batch
Fixes #1441