Support xcopied sdk #11530
Merged
Support xcopied sdk #11530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
May 11, 2021
|
@brettfo if you're fine with it, I would love to have it in main, so resolver can work with preview versions of sdk (which will allow us to upgrade to 6.0-preview). |
cartermp
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11522
An xcopied sdk is often used in ci's to ensure that the build is not dependent on the version of dotnetsdk installed on the vm. It makes things more reproducible.
On Windows an xcopied sdk can cause things like pack and sdk directories may exist in two locations, 1. the xcopied sdk, and 2. the global Sdk.
This PR updates how we probe for dotnet.exe and how we probe for pack and sdk directories.
Todo:
Edit: I also updated the global.json to use the arcade specified dotnetsdk in the ci.