Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new user-jwts tool into installer (#13895) #13913

Merged
merged 3 commits into from
Jun 7, 2022

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Jun 4, 2022

Forward port of #13895 to preview6.

Depends on #13860.

@captainsafia captainsafia requested a review from a team as a code owner June 4, 2022 00:00
Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but should there be a test or two of the tool in this repo❔

@dougbu
Copy link
Member

dougbu commented Jun 6, 2022

I think my question is mostly for you @marcpopMSFT

@captainsafia
Copy link
Member Author

This looks good to me but should there be a test or two of the tool in this repo❔

There are tests that validate the dotnt CLI in the SDK repo that I updated via dotnet/sdk#25757

@marcpopMSFT
Copy link
Member

SDK repo is for depth feature testing. The installer repo is more for breadth E2E testing (technically we can choose to run sdk tests in this repo as well). I'd put tests in the sdk repo as Safia has done and I probably wouldn't include it in the set of sdk tests run here.

Copy link
Member

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All set then

@captainsafia captainsafia merged commit 116a6a8 into main Jun 7, 2022
@captainsafia captainsafia deleted the safia/user-jwts-preview6 branch June 7, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants