Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-build: stop overriding aspnetcore version #14938

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

tmds
Copy link
Member

@tmds tmds commented Nov 9, 2022

Rename MicrosoftAspNetCoreAppRuntimePackageVersion so existing Artifacts tarballs don't override it,
and stop adding it to the PackageVersions.props in new Artifacts tarballs.

Related to dotnet/source-build#3121.

cc @ayakael @MichaelSimons @crummel

…cts tarballs don't override it,

and stop adding it to the PackageVersions.props in new Artifacts tarballs.
@MichaelSimons
Copy link
Member

My understanding is the renamed property is temporary until the previous source-build artifacts have been updated to not include the extra property in the PackageVersions.props file. Given the rename affects the official source and is not very localized, what do you think about adding a call to ReplaceRegexInFiles to simply remove the extra property in the PackageVersions.props file? This will validate the end state we want to get to works as expected now. This could be done where we copy the file into the artifacts.

crummel pushed a commit to ayakael/installer that referenced this pull request Nov 15, 2022
@tmds
Copy link
Member Author

tmds commented Nov 15, 2022

what do you think about adding a call to ReplaceRegexInFiles to simply remove the extra property in the PackageVersions.props file? This will validate the end state we want to get to works as expected now. This could be done where we copy the file into the artifacts.

I've implemented this. I had to move the ReplaceRegexInFiles after BuildXPlatTasks to be able to use the task.

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for refactoring to limit the impact of the temporary workaround. I have one minor comment.

@tmds
Copy link
Member Author

tmds commented Nov 15, 2022

@ayakael do you want to verify the patch works with the Alpine build?

@ayakael
Copy link

ayakael commented Nov 15, 2022

@ayakael do you want to verify the patch works with the Alpine build?

Sure, I'll do that right away.

@ayakael
Copy link

ayakael commented Nov 15, 2022

@tmds Testing against 7.0.100-rtm.22521.12, Alpine looks good. I'll update release/6.0 backport :))

@MichaelSimons MichaelSimons merged commit a8dcd1e into dotnet:main Nov 15, 2022
ayakael added a commit to ayakael/installer that referenced this pull request Nov 15, 2022
ayakael added a commit to ayakael/installer that referenced this pull request Nov 16, 2022
cho-m added a commit to cho-m/formula-patches that referenced this pull request Dec 7, 2022
cho-m added a commit to Homebrew/formula-patches that referenced this pull request Dec 7, 2022
ayakael added a commit to ayakael/installer that referenced this pull request Dec 16, 2022
ayakael added a commit to ayakael/installer that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants