Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET Source-Build 8.0.100-preview.2.23157.25 March 2023 Updates #15796

Conversation

dotnet-sb-bot
Copy link

Source-build updates for the .NET 8.0.0-preview.2.23128.3 / 8.0.100-preview.2.23157.25 March 2023 release.

@dotnet-sb-bot dotnet-sb-bot requested a review from a team as a code owner March 14, 2023 17:50
@MichaelSimons
Copy link
Member

Can the OverrideBootstrapVersions.props be removed as well in main?

@crummel
Copy link

crummel commented Mar 14, 2023

Yes, I think so, removed it.

@crummel crummel enabled auto-merge (squash) March 15, 2023 15:12
@crummel crummel merged commit 8d399ca into dotnet:release/8.0.1xx-preview2 Mar 15, 2023
@MichaelSimons
Copy link
Member

@crummel, @premun - I just realized this was opened against the wrong branch. This should be opened against main. Can you please ensure the release automation handles this correctly for preview.3? Also going forward the PrivateSourceBuiltSdkUrl_CentOS8Stream property needs updating.

@mthalman
Copy link
Member

I'll create a PR to merge this to main.

@mthalman
Copy link
Member

mthalman commented Mar 17, 2023

@premun - This will also require updates to https://github.com/dotnet/source-build/blob/main/eng/submit-source-build-release-pr.sh due to the property changes made in #15603.

@premun
Copy link
Member

premun commented Mar 17, 2023

Thanks, I will take care of the SB release pipeline changes

@premun
Copy link
Member

premun commented Mar 17, 2023

Apologies, I won't be able to make the other change around Version.props myself today and I am OOF the whole next week. Can someone take this?

@MichaelSimons
Copy link
Member

Apologies, I won't be able to make the other change around Version.props myself today and I am OOF the whole next week. Can someone take this?

I don't see this as needing to be completed now, the pipeline won't be run again until April servicing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants