Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify license header #1242

Merged
merged 1 commit into from
Nov 2, 2020
Merged

Simplify license header #1242

merged 1 commit into from
Nov 2, 2020

Conversation

richlander
Copy link
Member

Ellerbach
Ellerbach approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was now so used to the 3 lines :-) Great it's simplified!

@pgrawehr
Copy link
Contributor

pgrawehr commented Nov 2, 2020

I guess the license header in each file has no legal impact anyway. Whoever uses the code must check the license details anyway. (If in doubt, not specifying a license would mean "no rights granted").

@krwq
Copy link
Member

krwq commented Nov 2, 2020

LGTM, @richlander why do we need license header at all? Isn't root LICENSE file enough?

joperezr
joperezr approved these changes Nov 2, 2020
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for doing this @richlander

@joperezr joperezr merged commit aa2ba37 into master Nov 2, 2020
@joperezr joperezr deleted the license branch November 2, 2020 20:31
@Ellerbach Ellerbach mentioned this pull request Nov 3, 2020
Merged
richlander added a commit that referenced this pull request Nov 6, 2020
@richlander
Simplify license header (#1242)
a742d0d
ZhangGaoxing pushed a commit to ZhangGaoxing/iot that referenced this pull request Mar 15, 2021
@richlander @ZhangGaoxing
Simplify license header (dotnet#1242)
d326af1
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Ellerbach Ellerbach Ellerbach approved these changes

@joperezr joperezr joperezr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richlander @pgrawehr @krwq @Ellerbach @joperezr