Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Attributes for virtual methods and overrides #2046

Merged
merged 16 commits into from
Jun 22, 2021

Commits on May 21, 2021

  1. Add analyzer logic to detect when a method has RUC or RAF but it's base

    method or override doesn't
    Use IL2046 to display errors for RUC
    Use IL3003 to display errors for RAF
    Add IL3003 to error-codes.md
    Add tests
    tlakollo committed May 21, 2021
    Configuration menu
    Copy the full SHA
    c26248e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    498d2b1 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Add interface/implementation logic

    Add support for properties and events
    Add more tests
    Use a single resource for different requiresattributes
    Change error code IL3003 to be generic to requiresattributes
    tlakollo committed May 25, 2021
    Configuration menu
    Copy the full SHA
    6d1f810 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2021

  1. Review interfaces at type level instead of member level

    Add test with explicit interface implementation
    tlakollo committed Jun 4, 2021
    Configuration menu
    Copy the full SHA
    33a0f83 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2021

  1. Preliminar changes to restructure the testing infrastructure as

    discussed in dotnet#2077
    Now interfaces matching are lookup on types instead of asking per member
    Added support for specifying in Expected Warning and LogContains where
    the diagnostic is spected to be produced by default is LinkerAndAnalyzer
    Renaming methods and classes to specify Requires instead of
    RequiresUnreferencedCode
    Merge branch 'main' of https://github.com/mono/linker into MatchOverrideAttributes
    tlakollo committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    984ad6f View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Revert changes that solve dotnet#2077

    Add Explicit Interface testing
    tlakollo committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    9b4418c View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Add support for nullable attribute operations

    PR comments
    tlakollo committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    3aeca4b View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Add support for adding metadata information into the compilation

    Create test were the attributes between metadata and source dont match
    tlakollo committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    9848eaa View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Divide warning code into 4 different warnings to have better diagnostics

    following the implementation of ObsoleteAttribute messages
    Verify in linker tests that the warnings for base and derived methods
    are generated correctly
    Add new warnings to error-codes.md
    Add new resource messages
    Missing testing on interface/implementation on linker
    tlakollo committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    ec8f3ac View commit details
    Browse the repository at this point in the history
  2. Found linker tests for mismatching attributes on RUC while using

    interfaces, changed from LogContains to ExpectedWarning to find the
    error codes easier
    
    Change condition for linker to ask about interfaces instead of asking if
    a method is virtual
    tlakollo committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    982cba1 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Merge branch 'main' of https://github.com/mono/linker into MatchOverr…

    …ideAttributes
    
    Add diagnostics to shared resource file
    tlakollo committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    f890f41 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Delete duplicate IL3003

    tlakollo committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    dd329b7 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Merge mismatch diagnostics into 1 per requires attribute

    Update documentation, resource and tests
    tlakollo committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    8f6c43d View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. PR comments

    tlakollo committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    562e840 View commit details
    Browse the repository at this point in the history
  2. Use shared message formatting

    PR Comments
    tlakollo committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    e312ccf View commit details
    Browse the repository at this point in the history
  3. PR comments

    tlakollo committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    660c872 View commit details
    Browse the repository at this point in the history